Merge lp://qastaging/~dobey/ubuntuone-installer/qt-foo into lp://qastaging/ubuntuone-installer

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 23
Merged at revision: 25
Proposed branch: lp://qastaging/~dobey/ubuntuone-installer/qt-foo
Merge into: lp://qastaging/ubuntuone-installer
Diff against target: 216 lines (+110/-26)
6 files modified
bin/ubuntuone-installer (+7/-17)
run-tests (+2/-3)
ubuntuone/installer/__init__.py (+33/-0)
ubuntuone/installer/gui.py (+7/-5)
ubuntuone/installer/tests/test_gui.py (+1/-1)
ubuntuone/installer/tests/test_installer.py (+60/-0)
To merge this branch: bzr merge lp://qastaging/~dobey/ubuntuone-installer/qt-foo
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Review via email: mp+93603@code.qastaging.launchpad.net

Commit message

Use the gireactor to run tests now
Add constants for the control panel and music store packages and command
Install and run the qt control panel now
Install the rhythmbox extension now, rather than the banshee one

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :
Download full text (7.0 KiB)

I'm getting these when running the tests, any idea what's going on?

ubuntuone.devtools.testcases.dbus
  DBusTestCase
    runTest ... [OK]
ubuntuone.installer.tests.test_gui
  GUITestCase
    test_initial_page ... [OK]
    test_page_switched ... Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/defer/__init__.py", line 475, in _inline_callbacks
    result = gen.send(result)
  File "/usr/lib/python2.7/dist-packages/aptdaemon/client.py", line 1613, in _run_transaction_helper
    daemon = get_aptdaemon(self.bus)
  File "/usr/lib/python2.7/dist-packages/aptdaemon/client.py", line 1687, in get_aptdaemon
    False),
  File "/usr/lib/python2.7/dist-packages/dbus/bus.py", line 241, in get_object
    follow_name_owner_changes=follow_name_owner_changes)
  File "/usr/lib/python2.7/dist-packages/dbus/proxies.py", line 248, in __init__
    self._named_service = conn.activate_name_owner(bus_name)
  File "/usr/lib/python2.7/dist-packages/dbus/bus.py", line 180, in activate_name_owner
    self.start_service_by_name(bus_name)
  File "/usr/lib/python2.7/dist-packages/dbus/bus.py", line 278, in start_service_by_name
    'su', (bus_name, flags)))
  File "/usr/lib/python2.7/dist-packages/dbus/connection.py", line 651, in call_blocking
    message, timeout)
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name org.debian.apt was not provided by any .service files
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/defer/__init__.py", line 475, in _inline_callbacks
    result = gen.send(result)
  File "/usr/lib/python2.7/dist-packages/aptdaemon/client.py", line 1613, in _run_transaction_helper
    daemon = get_aptdaemon(self.bus)
  File "/usr/lib/python2.7/dist-packages/aptdaemon/client.py", line 1687, in get_aptdaemon
    False),
  File "/usr/lib/python2.7/dist-packages/dbus/bus.py", line 241, in get_object
    follow_name_owner_changes=follow_name_owner_changes)
  File "/usr/lib/python2.7/dist-packages/dbus/proxies.py", line 248, in __init__
    self._named_service = conn.activate_name_owner(bus_name)
  File "/usr/lib/python2.7/dist-packages/dbus/bus.py", line 180, in activate_name_owner
    self.start_service_by_name(bus_name)
  File "/usr/lib/python2.7/dist-packages/dbus/bus.py", line 278, in start_service_by_name
    'su', (bus_name, flags)))
  File "/usr/lib/python2.7/dist-packages/dbus/connection.py", line 651, in call_blocking
    message, timeout)
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name org.debian.apt was not provided by any .service files
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name org.debian.apt was not provided by any .service files
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/defer/__init__.py", line 473, in _inline_callbacks
    result = gen.throw(result.type, result.value, result.traceback)
  File "/home/nessita/canonical/installer/review_qt-foo/ubuntuone/installer/gui.py", line 377, in __update_cache
    sources_list='ubuntuone-stable-ppa.list')
dbus.exce...

Read more...

review: Needs Information
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Is worth noting that all the errors above are also present in trunk. Since the code itself looks good, can you please create a big for the DBus errors? I'm approving this branch.

review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :
Download full text (11.6 KiB)

The attempt to merge lp:~dobey/ubuntuone-installer/qt-foo into lp:ubuntuone-installer failed. Below is the output from the failed tests.

ubuntuone.devtools.testcases.dbus
  DBusTestCase
    runTest ... [OK]
ubuntuone.installer.tests.test_gui
  GUITestCase
    test_initial_page ... [OK]
    test_page_switched ... Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/defer/__init__.py", line 475, in _inline_callbacks
    result = gen.send(result)
  File "/usr/lib/python2.7/dist-packages/aptdaemon/client.py", line 1613, in _run_transaction_helper
    daemon = get_aptdaemon(self.bus)
  File "/usr/lib/python2.7/dist-packages/aptdaemon/client.py", line 1687, in get_aptdaemon
    False),
  File "/usr/lib/python2.7/dist-packages/dbus/bus.py", line 241, in get_object
    follow_name_owner_changes=follow_name_owner_changes)
  File "/usr/lib/python2.7/dist-packages/dbus/proxies.py", line 248, in __init__
    self._named_service = conn.activate_name_owner(bus_name)
  File "/usr/lib/python2.7/dist-packages/dbus/bus.py", line 180, in activate_name_owner
    self.start_service_by_name(bus_name)
  File "/usr/lib/python2.7/dist-packages/dbus/bus.py", line 278, in start_service_by_name
    'su', (bus_name, flags)))
  File "/usr/lib/python2.7/dist-packages/dbus/connection.py", line 651, in call_blocking
    message, timeout)
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name org.debian.apt was not provided by any .service files
OSError: [Errno 2] No such file or directory: '/var/crash/_usr_bin_u1trial.1001.crash'
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/defer/__init__.py", line 475, in _inline_callbacks
    result = gen.send(result)
  File "/home/tarmac/cache/ubuntuone-installer/trunk/ubuntuone/installer/gui.py", line 377, in __update_cache
    sources_list='ubuntuone-stable-ppa.list')
  File "/usr/lib/python2.7/dist-packages/defer/utils.py", line 105, in _deferable
    func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/aptdaemon/errors.py", line 183, in _convert_dbus_exception
    return func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/aptdaemon/client.py", line 1489, in update_cache
    wait, reply_handler, error_handler)
  File "/usr/lib/python2.7/dist-packages/aptdaemon/client.py", line 1576, in _run_transaction
    error_handler(error)
  File "/usr/lib/python2.7/dist-packages/aptdaemon/errors.py", line 181, in <lambda>
    lambda err: error_handler(get_native_exception(err))
  File "/usr/lib/python2.7/dist-packages/defer/utils.py", line 104, in <lambda>
    kwargs["error_handler"] = lambda err: on_error(err, deferred)
  File "/usr/lib/python2.7/dist-packages/defer/utils.py", line 87, in on_error
    deferred.errback(DeferredException(error))
  File "/usr/lib/python2.7/dist-packages/defer/__init__.py", line 351, in errback
    self._next()
  File "/usr/lib/python2.7/dist-packages/defer/__init__.py", line 407, in _next
    self.result.traceback)
  File "/usr/lib/python2.7/dist-packages/apport_python_hook.py", line 126, in apport_excepthoo...

23. By dobey

Don't need to rm .coverage without doing the coverage report any more

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: