Merge lp://qastaging/~docky-core/docky/composite-notify into lp://qastaging/docky

Proposed by Robert Dyer
Status: Merged
Merged at revision: 1737
Proposed branch: lp://qastaging/~docky-core/docky/composite-notify
Merge into: lp://qastaging/docky
Diff against target: 86 lines (+28/-3)
3 files modified
Docky/Docky.csproj (+3/-0)
Docky/Docky/Docky.cs (+24/-3)
Docky/Makefile.am (+1/-0)
To merge this branch: bzr merge lp://qastaging/~docky-core/docky/composite-notify
Reviewer Review Type Date Requested Status
Rico Tzschichholz Approve
Docky Core Pending
Review via email: mp+42423@code.qastaging.launchpad.net

Description of the change

This branch does 2 things:

1) Waits 8 seconds during Docky startup to look for compositing, which might help work around all the complaints we get regarding the notify showing on startup (because Docky starts before compositing is enabled). In all other cases when compositing 'changes' it waits 2 seconds then checks (same as before).

2) When compositing is checked on a change, it immediately looks if a notify is shown and if so it closes it. Thus, if we notify that compositing is not available and it suddenly comes available it will immediately request to close that notify (instead of waiting for it to time out).

To post a comment you must log in.
Revision history for this message
Robert Dyer (psybers) wrote :

Note that I have not tested this. We would need to test it still, assuming the code 'looks' fine.

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

> Note that I have not tested this. We would need to test it still, assuming
> the code 'looks' fine.

So test it ;-)
Code looks fine. but I would hand over the timeout as milliseconds to CheckComposite.

1708. By Rico Tzschichholz

small optimization

Revision history for this message
Rico Tzschichholz (ricotz) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: