gallery-app

Merge lp://qastaging/~doflah/gallery-app/reuse_delete_dialog into lp://qastaging/gallery-app

  1. reuse_delete_dialog
  2. Merge into trunk
Proposed by Dennis O'Flaherty
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp://qastaging/~doflah/gallery-app/reuse_delete_dialog
Merge into: lp://qastaging/gallery-app
Diff against target: 103 lines (+6/-45)
3 files modified
rc/qml/MediaViewer/MediaViewer.qml (+4/-21)
tests/autopilot/gallery_app/emulators/photo_viewer.py (+0/-22)
tests/autopilot/gallery_app/tests/test_photo_viewer.py (+2/-2)
To merge this branch: bzr merge lp://qastaging/~doflah/gallery-app/reuse_delete_dialog
Reviewer Review Type Date Requested Status
Arthur Mello (community) Needs Fixing
Review via email: mp+218541@code.qastaging.launchpad.net

Description of the change

One of the delete dialogs didn't have the correct color scheme. This patch fixes it: ok -> orange, cancel -> gray.

To post a comment you must log in.
Revision history for this message
Arthur Mello (artmello) wrote :

We now have two delete dialog options, the old one changed by this MR and a new one, for when the photo is inside an album. Would be good to update both of them to have this feature.

review: Needs Fixing
Revision history for this message
Sebastien Bacher (seb128) wrote :

the issue is resolved, rejecting the change it's not needed

Unmerged revisions

955. By Dennis O'Flaherty

Use the DeleteDialog in the PhotoViewer for consistency

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches