Merge lp://qastaging/~donadigo/slingshot/fix-app-ranking into lp://qastaging/~elementary-pantheon/slingshot/trunk
Proposed by
Adam Bieńkowski
| Status: | Merged |
|---|---|
| Approved by: | David Hewitt |
| Approved revision: | 754 |
| Merged at revision: | 753 |
| Proposed branch: | lp://qastaging/~donadigo/slingshot/fix-app-ranking |
| Merge into: | lp://qastaging/~elementary-pantheon/slingshot/trunk |
| Diff against target: |
140 lines (+62/-61) 1 file modified
lib/synapse-plugins/desktop-file-plugin.vala (+62/-61) |
| To merge this branch: | bzr merge lp://qastaging/~donadigo/slingshot/fix-app-ranking |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| David Hewitt | code, function | Approve | |
|
Review via email:
|
|||
Commit message
* Fix app ranking being incorrect about keywords
Description of the change
This branch aims to fix app rankings, and keyword queries which are currently incorrectly handeled (as well as actions).
The code should be easier to read and understand now since matchers are iterated only twice for app searching and action searching. Some of the statements caused returning the highest possible values for a match, these are now removed, I've also adjusted current values a little bit.
To post a comment you must log in.
Revision history for this message
| David Hewitt (davidmhewitt) wrote | # |
review:
Approve
(code, function)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I've tried all of the apps that come with elementary in the search plus a few others and all the results were as I'd expect. So this has definitely fixed the weird ordering of some of the results.