Merge lp://qastaging/~donadigo/slingshot/open-link-browser into lp://qastaging/~elementary-pantheon/slingshot/trunk
Proposed by
Adam Bieńkowski
| Status: | Merged |
|---|---|
| Approved by: | Danielle Foré |
| Approved revision: | 635 |
| Merged at revision: | 634 |
| Proposed branch: | lp://qastaging/~donadigo/slingshot/open-link-browser |
| Merge into: | lp://qastaging/~elementary-pantheon/slingshot/trunk |
| Diff against target: |
216 lines (+150/-4) 5 files modified
lib/synapse-plugins/CMakeLists.txt (+1/-0) lib/synapse-plugins/link-plugin.vala (+140/-0) src/Backend/SynapseSearch.vala (+2/-1) src/Widgets/SearchItem.vala (+2/-1) src/Widgets/SearchView.vala (+5/-2) |
| To merge this branch: | bzr merge lp://qastaging/~donadigo/slingshot/open-link-browser |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Danielle Foré | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Fix bug #1487786 "When entering web address, offer to open default browser [$15]".
Description of the change
Fix bug #1487786 "When entering web address, offer to open default browser [$15]".
I tried to keep the diff as small as possible, regex allows to open links with "https" and without it, plugin gets default browser by what's displayed in the applications plug. Tested with Midori, Chrome and Firefox.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hrm I'm not sure how terribly useful this is when the regex requires x.y.z format or http(s). I would expect that most users write urls like foo.bar as a common case