Slingshot

Merge lp://qastaging/~donadigo/slingshot/show-app-badges-new into lp://qastaging/~elementary-pantheon/slingshot/trunk

  1. show-app-badges-new
  2. Merge into trunk
Proposed by Adam Bieńkowski
Status: Merged
Approved by: Cody Garver
Approved revision: 633
Merged at revision: 635
Proposed branch: lp://qastaging/~donadigo/slingshot/show-app-badges-new
Merge into: lp://qastaging/~elementary-pantheon/slingshot/trunk
Diff against target: 231 lines (+114/-4)
4 files modified
src/Backend/App.vala (+37/-1)
src/Slingshot.vala (+7/-1)
src/SlingshotView.vala (+37/-1)
src/Widgets/AppEntry.vala (+33/-1)
To merge this branch: bzr merge lp://qastaging/~donadigo/slingshot/show-app-badges-new
Reviewer Review Type Date Requested Status
elementary Pantheon team Pending
Review via email: mp+286386@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2016-02-12.

Commit message

* Fixes bug #710498: "Support Launcher API in order to show badges".

Description of the change

This branch fixes bug #710498 "Support Launcher API in order to show badges".

The implementation is done entirely by using the new plank UnityClient and Surface API.

NOTE: In order to have app badges shown in the Slingshot, you must have plank version greater or equal to r1490 (compiled from trunk).

To post a comment you must log in.
Revision history for this message
Rico Tzschichholz (ricotz) wrote : Posted in a previous version of this proposal

Hmm, didn't you realize that this is public API of libplank?

Revision history for this message
Adam Bieńkowski (donadigo) wrote : Posted in a previous version of this proposal

ricotz: Ahhh, sory, I didn't realize that I could use the UnityClient interface directly. Thanks for pointing out, it now uses only the libplank API. Branch updated.

Revision history for this message
Rico Tzschichholz (ricotz) wrote : Posted in a previous version of this proposal

if application.count_visible is true you should not draw anything, so don't uselessly call draw_item_count().

Revision history for this message
Ezekiel Michael Angel (nolenumar) wrote :

Please stop sending me these emails
On Feb 22, 2016 6:13 PM, <email address hidden> wrote:

> The proposal to merge lp:~donadigo/slingshot/show-app-badges-new into
> lp:slingshot has been updated.
>
> Status: Approved => Merged
>
> For more details, see:
>
> https://code.launchpad.net/~donadigo/slingshot/show-app-badges-new/+merge/286386
> --
> You are subscribed to branch lp:slingshot.
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches