Merge lp://qastaging/~donadigo/switchboard-plug-networking/common-rewrite into lp://qastaging/~elementary-pantheon/switchboard-plug-networking/trunk

see diff comments.

please use smaller functions instead of 40+lines in a update function.

don't duplicade code

anduse proper get set functions instead of those ugly property implementation

kay20: I did fix some of your issues, but not all of them, because I do not agree with them, and the elementary code-style has changed so:

- We don't use "this" anymore. It's used for the case where you have a property and you want to assign it from the parameter like this:
this.a = a;

- I don't agree there should be white lines between the variable creation and checking it for something, simply because it looks for me better and actually holds the concept that this assignment is now verified.

- I moved the portions of the code to shorter methods, however I still couldn't make them all, because they use a lot of variables they depend on and if I would make them into smaller methods, these would need to have parameters, but I agree into moving the code to smaller methods, this branch isn't just place for this.

Some comments inline.

I'm not familiarised with the network plug, so I'm not aware of all the subtleties but I did not notice anything fundamentally wrong.

Ideally, changes like this should be done in smaller merges in the future.

There are also some merge commits.

matzipan: I addressed all your issues, except the label styling and unmanaged state of NetworkManager. These should probably be done in a different branch, the code you're seeing is just copied and refactored into more elegant code structure.

Whoops. Meant to say there are some merge conflicts and ended up saying there are some merge commits.