Merge lp://qastaging/~dooferlad/linaro-image-tools/fetch_image_gui into lp://qastaging/linaro-image-tools/11.11
Proposed by
James Tunnicliffe
Status: | Rejected |
---|---|
Rejected by: | Loïc Minier |
Proposed branch: | lp://qastaging/~dooferlad/linaro-image-tools/fetch_image_gui |
Merge into: | lp://qastaging/linaro-image-tools/11.11 |
Prerequisite: | lp://qastaging/~dooferlad/linaro-image-tools/fetch_image_server_indexer |
Diff against target: |
1749 lines (+1740/-0) 2 files modified
fetch_image.py (+79/-0) fetch_image_ui.py (+1661/-0) |
To merge this branch: | bzr merge lp://qastaging/~dooferlad/linaro-image-tools/fetch_image_gui |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Westby (community) | Approve | ||
Review via email:
|
This proposal supersedes a proposal from 2011-06-17.
Description of the change
Initial merge request of fetch_image_ui.py - a GUI with similar functionality to fetch_image.py.
The GUI guides the user through the process of creating an image for their ARM hardware. Files are pulled as required from release.linaro.org and snapshots.
--
Now with split up unit tests!
To post a comment you must log in.
Unmerged revisions
- 362. By James Tunnicliffe
-
Slight style clean up.
- 361. By James Tunnicliffe
-
Split unit test into three cases.
133 + if(style != None): bind_to, label = label, style = style) bind_to, label = label)
134 + radio_button = wx.RadioButton(
135 + else:
136 + radio_button = wx.RadioButton(
I think that's unnecessary isn't it? style=None is usually the default.
(also we usually avoid spaces around = in method calls)
226 + if "panda" in self.settings[ 'choice' ]['hardware' ].keys( ):
227 + default_hardware = "panda"
Was this just to make your testing easier? I don't think that the choice should
have a default until we're in a position to remember their last answer.
1562 + def test_url_ lookup( self):
Please break up this test in to several tests. These sort of test cases
are a nightmare to debug. Ideally each test method should assert a single
thing.
Thanks,
James