linaro-license-protection

Merge lp://qastaging/~dooferlad/linaro-license-protection/add_api into lp://qastaging/~linaro-automation/linaro-license-protection/trunk

Proposed by James Tunnicliffe on 2013-03-11

Status:	Merged
Approved by:	Milo Casagrande on 2013-03-12
Approved revision:	177
Merged at revision:	177
Proposed branch:	lp://qastaging/~dooferlad/linaro-license-protection/add_api
Merge into:	lp://qastaging/~linaro-automation/linaro-license-protection/trunk
Diff against target:	395 lines (+294/-6) 5 files modified HACKING (+28/-0) license_protected_downloads/tests/test_views.py (+104/-0) license_protected_downloads/views.py (+67/-6) scripts/download.py (+89/-0) urls.py (+6/-0)
To merge this branch:	bzr merge lp://qastaging/~dooferlad/linaro-license-protection/add_api
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Milo Casagrande (community)		2013-03-11	Approve on 2013-03-12
Review via email: mp+152717@code.qastaging.launchpad.net

Adds an API for clients to use to download files. For sample usage see scripts/download.py.

Revision history for this message

Milo Casagrande (milo) wrote on 2013-03-12:

Hi James, thanks for working on this.

It looks to go for me.
A couple of things that can be fixed during merge:

216 +# Generate the URL that will return the license information. This is the URL
217 +# if the file with /api/license prepended to the path.

I guess there is a small type there: s/if the file/of the file

Another thing that might be good is to add something in the HACKING file about the new changes/API.

review: Approve

178. By James Tunnicliffe on 2013-03-12: Added information about the API to the HACKING document.
Added test for the listing API.
Updated download.py to use all parts of the API, demonstrating how to download all files in a directory, perform interactive checks with the user for if they accept a license and storing which licenses the user accepts so they don't have to re-accept a license they have alread read.
179. By James Tunnicliffe on 2013-03-12: Added tests to check failure mode of API.