Merge lp://qastaging/~dooferlad/linaro-license-protection/logout-link-on-openid-denied into lp://qastaging/~linaro-automation/linaro-license-protection/trunk
Proposed by
James Tunnicliffe
| Status: | Merged |
|---|---|
| Approved by: | James Tunnicliffe |
| Approved revision: | 113 |
| Merged at revision: | 114 |
| Proposed branch: | lp://qastaging/~dooferlad/linaro-license-protection/logout-link-on-openid-denied |
| Merge into: | lp://qastaging/~linaro-automation/linaro-license-protection/trunk |
| Diff against target: |
91 lines (+57/-5) 3 files modified
license_protected_downloads/openid_auth.py (+23/-4) license_protected_downloads/tests/test_openid_auth.py (+17/-1) templates/openid_forbidden_template.html (+17/-0) |
| To merge this branch: | bzr merge lp://qastaging/~dooferlad/linaro-license-protection/logout-link-on-openid-denied |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stevan Radaković | Approve | ||
|
Review via email:
|
|||
Description of the change
Add a custom HTTP response forbidden page when we fail to be part of the correct Launchpad team to allow access to a file. The page lists the teams that you need to be a member of and allows you to log in again to give you the opportunity to make sure that you share the right team membership to give you file access (if you have it).
To post a comment you must log in.
Revision history for this message
| James Tunnicliffe (dooferlad) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Since you're using template, I'd rather you just pass the openid_teams as an array to the template and construct the teams string over there... Does this sound viable?