LP2Kanban

Merge lp://qastaging/~dpb/lp2kanban/use-logging into lp://qastaging/lp2kanban

  1. use-logging
  2. Merge into trunk
Proposed by David Britton
Status: Merged
Approved by: David Britton
Approved revision: 165
Merged at revision: 143
Proposed branch: lp://qastaging/~dpb/lp2kanban/use-logging
Merge into: lp://qastaging/lp2kanban
Prerequisite: lp://qastaging/~dpb/lp2kanban/filter-bugs-correct-movement
Diff against target: 432 lines (+81/-81)
2 files modified
src/lp2kanban/bugs2cards.py (+74/-73)
src/lp2kanban/tests/test_bugs2cards.py (+7/-8)
To merge this branch: bzr merge lp://qastaging/~dpb/lp2kanban/use-logging
Reviewer Review Type Date Requested Status
🤖 Landscape Builder test results Approve
Alberto Donato (community) Approve
Review via email: mp+304293@code.qastaging.launchpad.net

Commit message

bugs2cards.py: Convert prints to logs

Description of the change

Convert prints to logs

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make check
Result: Fail
Revno: 163
Branch: lp:~davidpbritton/lp2kanban/use-logging
Jenkins: https://ci.lscape.net/job/latch-test/9628/

review: Needs Fixing (test results)
lp://qastaging/~dpb/lp2kanban/use-logging updated
164. By David Britton

Merge up along filter branch

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: http_proxy=$ci_proxy https_proxy=$ci_proxy make ci-test
Result: Success
Revno: 164
Branch: lp:~davidpbritton/lp2kanban/use-logging
Jenkins: https://ci.lscape.net/job/latch-test/9631/

review: Approve (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: http_proxy=$CI_PROXY https_proxy=$CI_PROXY make ci-test
Result: Success
Revno: 164
Branch: lp:~davidpbritton/lp2kanban/use-logging
Jenkins: https://ci.lscape.net/job/latch-test/9633/

review: Approve (test results)
Revision history for this message
Alberto Donato (ack) wrote :

Nice! +1

Small nit inline.

Also, it'd be nice to convert all %-formatting to .format() while you are at it.

review: Approve
lp://qastaging/~dpb/lp2kanban/use-logging updated
165. By David Britton

Merge up from filter-bugs...

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: http_proxy=$CI_PROXY https_proxy=$CI_PROXY make ci-test
Result: Fail
Revno: 165
Branch: lp:~davidpbritton/lp2kanban/use-logging
Jenkins: https://ci.lscape.net/job/latch-test/10139/

review: Needs Fixing (test results)
Revision history for this message
David Britton (dpb) wrote :

fixed all comments from ack

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: http_proxy=$CI_PROXY https_proxy=$CI_PROXY make ci-test
Result: Success
Revno: 165
Branch: lp:~davidpbritton/lp2kanban/use-logging
Jenkins: https://ci.lscape.net/job/latch-test/10141/

review: Approve (test results)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: