address-book-app

Merge lp://qastaging/~dpm/address-book-app/small-i18n-fixes into lp://qastaging/address-book-app

  1. small-i18n-fixes
  2. Merge into trunk
Proposed by David Planella
Status: Rejected
Rejected by: Renato Araujo Oliveira Filho
Proposed branch: lp://qastaging/~dpm/address-book-app/small-i18n-fixes
Merge into: lp://qastaging/address-book-app
Diff against target: 37 lines (+3/-3)
3 files modified
src/imports/ContactView/ContactFetchError.qml (+1/-1)
src/imports/MainWindow.qml (+1/-1)
src/imports/Ubuntu/Contacts/ContactDetailPickerPhoneNumberDelegate.qml (+1/-1)
To merge this branch: bzr merge lp://qastaging/~dpm/address-book-app/small-i18n-fixes
Reviewer Review Type Date Requested Status
Leo Arias (community) Approve
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+228932@code.qastaging.launchpad.net

Commit message

Marks for translation the "No phone numbers" message that appears when a contact has no numbers set.

Description of the change

Marks for translation the "No phone numbers" message that appears when a contact has no numbers set. A couple of other untranslatable messages have been fixed as well.

This branch (or a follow-up one) should probably update the .pot file as well, but I couldn't figure out how it's done in system apps. Is there a cmake rule to do it? Any hints welcome!

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:259
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/654/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-amd64-ci/107
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-armhf-ci/107
        deb: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-armhf-ci/107/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-i386-ci/107
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2765
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2206
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2855
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4008
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4008/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10718
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1826
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2465
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2465/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/654/rebuild

review: Approve (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

Thanks David.

review: Approve
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

replaced by
https://code.launchpad.net/~renatofilho/address-book-app/update-translation/+merge/230556

Unmerged revisions

259. By David Planella

Marked several strings for translation

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches