Ubuntu Notes app

Merge lp://qastaging/~dpm/reminders-app/debian-copyright into lp://qastaging/reminders-app

debian-copyright
Merge into trunk

Proposed by David Planella on 2014-07-04

Status:

Work in progress

Proposed branch:

lp://qastaging/~dpm/reminders-app/debian-copyright

Merge into:

lp://qastaging/reminders-app

Diff against target:

34 lines (+20/-0)

1 file modified

debian/copyright (+20/-0)

To merge this branch:

bzr merge lp://qastaging/~dpm/reminders-app/debian-copyright

Low

Triaged

Link a bug report

Reviewer	Review Type	Date Requested	Status
Nicholas Skaggs (community)			Needs Fixing on 2014-07-16
Daniel Holbach (community)			Needs Fixing on 2014-07-09
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2014-07-04
Michael Zanetti (community)		2014-07-04	Approve on 2014-07-04
Review via email: mp+225646@code.qastaging.launchpad.net

Commit message

Add copyright information to the Debian packaging, including those files licensed under the Apache-2.0 license

Description of the change

Add copyright information to the Debian packaging, including those files licensed under the Apache-2.0 license

There were a few things I wasn't sure about, it'd be good if someone knowledgeable on licenses would review them:

- There is no information about which year the copyright applies to in the license headers in src/3rdParty/libthrift, thus I've left the year in debian/copyright for that entry blank.
- The files under src/3rdParty/evernote-sdk-cpp were generated automatically by Thrift at Evernote. They have no license information, thus I'm assuming they have the same license as the files under src/3rdParty/libthrift

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2014-07-04:

ack. cheers.

review: Approve

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-07-04:

PASSED: Continuous integration, rev:175
http://91.189.93.70:8080/job/reminders-app-ci/449/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/893
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/893/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/145

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/449/rebuild

review: Approve (continuous-integration)

Revision history for this message

Daniel Holbach (dholbach) wrote on 2014-07-09:

This is missing the following:

- tests/autopilot/thrift/*, ./3rdParty/libthrift/: Apache (v2.0)
- 3rdParty/evernote-sdk-cpp/: BSD (2 clause)

The following files are GPL v3 or later:
./src/app/camerahelper.cpp: GPL (v3 or later)
./src/app/preferences.cpp: GPL (v3 or later)
./src/app/preferences.h: GPL (v3 or later)
./src/app/camerahelper.h: GPL (v3 or later)
./src/app/main.cpp: GPL (v3 or later)

This file is LGPL v3:
./tests/autopilot/reminders/tests/__init__.py

review: Needs Fixing

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-07-16:

Add https://github.com/evernote/evernote-sdk-python3/blob/master/LICENSE

for tests/autopilot/evernote/*

review: Needs Fixing