Ubuntu Document Viewer App

Merge lp://qastaging/~dpm/ubuntu-docviewer-app/toolbar-fix into lp://qastaging/ubuntu-docviewer-app/trunk

  1. toolbar-fix
  2. Merge into trunk
Proposed by Daniel Holm
Status: Rejected
Rejected by: Anthony Granger
Proposed branch: lp://qastaging/~dpm/ubuntu-docviewer-app/toolbar-fix
Merge into: lp://qastaging/ubuntu-docviewer-app/trunk
Diff against target: 126 lines (+28/-17)
4 files modified
ImageView.qml (+1/-1)
PdfView.qml (+1/-1)
TextView.qml (+1/-1)
ubuntu-docviewer-app.qml (+25/-14)
To merge this branch: bzr merge lp://qastaging/~dpm/ubuntu-docviewer-app/toolbar-fix
Reviewer Review Type Date Requested Status
Anthony Granger Disapprove
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Review via email: mp+186499@code.qastaging.launchpad.net

Commit message

Updated Toolbar API

Description of the change

Why is this not already proposed? The app doesn't run with the old toolbar code.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:21
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/1/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests/418/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-docviewer-app-precise-amd64-ci/1/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-docviewer-app-quantal-amd64-ci/1/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-docviewer-app-raring-amd64-ci/1/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-docviewer-app-saucy-amd64-ci/1/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/1/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Anthony Granger (chocanto) wrote :

It's ok, I have fix the bug in the "file-qml" branch !

Thank you !

review: Disapprove

Unmerged revisions

21. By David Planella

Merged from Anthony Granger's branch

20. By David Planella

Migrated to the new Toolbar API

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches