Merge lp://qastaging/~dpniel/ubuntu-autopilot-tests/alternative_firefox into lp://qastaging/ubuntu-autopilot-tests
Proposed by
Dan Chapman
| Status: | Merged |
|---|---|
| Merged at revision: | 53 |
| Proposed branch: | lp://qastaging/~dpniel/ubuntu-autopilot-tests/alternative_firefox |
| Merge into: | lp://qastaging/ubuntu-autopilot-tests |
| Diff against target: |
146 lines (+37/-35) 1 file modified
ubuntu_autopilot_tests/firefox/test_firefox.py (+37/-35) |
| To merge this branch: | bzr merge lp://qastaging/~dpniel/ubuntu-autopilot-tests/alternative_firefox |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Nicholas Skaggs (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
I have created an alternative firefox test.
Instead of autopilot typing in the URL i have forced jenkins to load on firefox loading. I noticed that start_app_window() when using ProcManager can have an optional list to load files on app launch. So using this to load jenkins page. I think it runs alot smoother now.
Also the fails we are seeing on jenkins is down to the keyboard and typing errors. And the org.ayatana.bamf seems to appear if a secondary window/tab opens. This route cuts all that out.
Let me know what you think
Dan
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This is certainly better than what we have -- any more weirdness you've seen running multiple iterations? If not, let's push it in! I like the changes to direct url load and cut down on the typing.. Also, adding asserts as mentioned wherever possible to help prevent us from blindly doing things is good :-)