Merge lp://qastaging/~dpniel/ubuntu-autopilot-tests/firefox_combined into lp://qastaging/ubuntu-autopilot-tests

Proposed by Dan Chapman 
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 56
Merged at revision: 56
Proposed branch: lp://qastaging/~dpniel/ubuntu-autopilot-tests/firefox_combined
Merge into: lp://qastaging/ubuntu-autopilot-tests
Diff against target: 74 lines (+28/-26)
1 file modified
ubuntu_autopilot_tests/firefox/test_firefox.py (+28/-26)
To merge this branch: bzr merge lp://qastaging/~dpniel/ubuntu-autopilot-tests/firefox_combined
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Approve
Review via email: mp+175259@code.qastaging.launchpad.net

Description of the change

I have combined the three current tests into one combined tests. If you view
the video here:

https://jenkins.qa.ubuntu.com/job/autopilot-ubuntu-applications/17/label=autopilot-ati/artifact/results/autopilot/videos/

You can see that the firefox process is not termianting quick enough between
one tests teardown and the next tests setup. It can take up to 10 seconds or so
for FF to terminate fully. So combining it into one tests wipes this out.

Let me know what you think, hopefully this will have to be the last edit :-)

Dan

To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

:-) I agree I hope this is the last edit.. Lesson learned for including non-introspectable apps into the production branch.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches