Merge lp://qastaging/~dpniel/ubuntu-calendar-app/uitk-1.3 into lp://qastaging/ubuntu-calendar-app

Proposed by Dan Chapman ξƒΏ
Status: Rejected
Rejected by: Alan Pope 🍺🐧🐱 πŸ¦„
Proposed branch: lp://qastaging/~dpniel/ubuntu-calendar-app/uitk-1.3
Merge into: lp://qastaging/ubuntu-calendar-app
Diff against target: 1583 lines (+372/-337)
49 files modified
AgendaView.qml (+2/-2)
AllDayEventComponent.qml (+2/-2)
CalendarChoicePopup.qml (+56/-60)
CalendarListButtonDelegate.qml (+28/-30)
ColorPickerDialog.qml (+3/-3)
ContactChoicePopup.qml (+2/-2)
DayHeaderBackground.qml (+1/-1)
DayView.qml (+2/-2)
DeleteConfirmationDialog.qml (+2/-2)
EditEventConfirmationDialog.qml (+2/-2)
EventActions.qml (+2/-2)
EventBubble.qml (+2/-2)
EventDetails.qml (+41/-23)
EventListModel.qml (+2/-2)
EventReminder.qml (+2/-2)
EventRepetition.qml (+8/-9)
EventUtils.qml (+2/-2)
HeaderDateComponent.qml (+2/-2)
KeyboardRectangle.qml (+1/-1)
LimitLabelModel.qml (+1/-1)
MonthComponent.qml (+2/-2)
MonthComponentDateDelegate.qml (+1/-1)
MonthView.qml (+2/-2)
NewEvent.qml (+80/-68)
NewEventEntryField.qml (+2/-2)
NewEventTimePicker.qml (+2/-2)
OnlineAccountsHelper.qml (+1/-1)
PathViewBase.qml (+1/-1)
RecurrenceLabelDefines.qml (+2/-2)
RemindersModel.qml (+1/-1)
ScrollAnimation.qml (+1/-1)
Scroller.qml (+2/-2)
SectionHeader.qml (+23/-0)
Settings.qml (+20/-31)
TimeLineBackground.qml (+2/-2)
TimeLineBase.qml (+2/-2)
TimeLineBaseComponent.qml (+10/-9)
TimeLineHeader.qml (+1/-1)
TimeLineHeaderComponent.qml (+2/-2)
TimeLineTimeScale.qml (+1/-1)
TimeSeparator.qml (+1/-1)
ViewHeader.qml (+2/-2)
WeekView.qml (+2/-2)
YearView.qml (+2/-3)
YearViewDelegate.qml (+2/-2)
calendar.qml (+4/-4)
calendarTests.qml (+2/-2)
click/manifest.json.in (+1/-1)
po/com.ubuntu.calendar.pot (+35/-35)
To merge this branch: bzr merge lp://qastaging/~dpniel/ubuntu-calendar-app/uitk-1.3
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Needs Fixing
Jenkins Bot continuous-integration Needs Fixing
Review via email: mp+283591@code.qastaging.launchpad.net

Commit message

Update to UITK 1.3

Description of the change

Update Calendar to Ubuntu.Components 1.3

All imports have been changed to reflect newer uitk,
also switched all ListItems to use the new ListItem & ListItemLayouts

Not sure if the autopilot tests are working or not. I can't seem to get the environment setup correctly on xenial :-/

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:745
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~dpniel/ubuntu-calendar-app/uitk-1.3/+merge/283591/+edit-commit-message

https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/161/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/442/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/161/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Build a click of this merge and installed on my device and it refuses to launch at all, which is odd.

review: Needs Fixing
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Also, this duplicates https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/Uitk1_3/+merge/276338, but this one appears to make further changes?

Revision history for this message
Dan Chapman ξƒΏ (dpniel) wrote :

Ooops sorry guys... I totally missed kunal's branch when I scanned the current branch list.

The further changes in this branch are from upgrading the listitems to the 1.3 ListItem & ListItemLayout and lose the old Ubuntu.Components.ListItems. I see kunal has made some other changes I didn't, so really we need to get them merged together. I'll rebase this and propose a merge against kunal's that updates the ListItems.

Not sure why the click wouldn't launch :-/ Was there anything in the log?

Unmerged revisions

745. By Dan Chapman ξƒΏ

Update Calendar to Ubuntu.Components 1.3

All imports have been changed to reflect newer uitk,
also switched all ListItems to use the new ListItem & ListItemLayouts

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: