Merge lp://qastaging/~dshea/timezonemap/location-cycle into lp://qastaging/timezonemap

Proposed by David Shea
Status: Merged
Merged at revision: 51
Proposed branch: lp://qastaging/~dshea/timezonemap/location-cycle
Merge into: lp://qastaging/timezonemap
Diff against target: 76 lines (+35/-7)
1 file modified
src/cc-timezone-map.c (+35/-7)
To merge this branch: bzr merge lp://qastaging/~dshea/timezonemap/location-cycle
Reviewer Review Type Date Requested Status
Iain Lane Approve
Review via email: mp+254831@code.qastaging.launchpad.net

Description of the change

An anaconda user noticed (https://bugzilla.redhat.com/show_bug.cgi?id=1190265) that if you repeatedly click the same spot on the map, it will choose different locations for each click (which is intentional), to the point where clicks will start jumping wildly across the map as the search area expands outwards (which is probably less intentional). While looking into this, I found that the handling of the repeated clicks resulted in a memory leak in priv->distances, and if you managed to get to the end of the list it would crash. The first patch addresses the memory problems, and the second limits the location search to a 50px radius.

To post a comment you must log in.
Revision history for this message
Adam Williamson (awilliamson) wrote :

Aw, no is_canada() ? :P

Revision history for this message
Iain Lane (laney) wrote :

Cool, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: