Merge lp://qastaging/~dsowen/charms/precise/postgresql/reload into lp://qastaging/charms/postgresql

Proposed by David Owen
Status: Merged
Merged at revision: 24
Proposed branch: lp://qastaging/~dsowen/charms/precise/postgresql/reload
Merge into: lp://qastaging/charms/postgresql
Diff against target: 19 lines (+3/-4)
2 files modified
hooks/db-relation-changed (+2/-3)
revision (+1/-1)
To merge this branch: bzr merge lp://qastaging/~dsowen/charms/precise/postgresql/reload
Reviewer Review Type Date Requested Status
charmers Pending
Review via email: mp+111247@code.qastaging.launchpad.net

Description of the change

Postgres is already running during the change hook (it has to be; the joined hook uses a running postgres, and I don't see that any relation hooks take the server down).

As we're only changing pg_hba.conf, only a reload, not a restart, is necessary. This keeps the server up and accepting TCP connections, guaranteeing the the other side of the relation can connect immediately without busy-waiting.

To post a comment you must log in.
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Great work thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches