Merge lp://qastaging/~duckx-mezimail/bzr-externals/bzr-externals-setup into lp://qastaging/bzr-externals

Proposed by duckx
Status: Merged
Merged at revision: not available
Proposed branch: lp://qastaging/~duckx-mezimail/bzr-externals/bzr-externals-setup
Merge into: lp://qastaging/bzr-externals
Diff against target: 30 lines (+26/-0)
1 file modified
setup.py (+26/-0)
To merge this branch: bzr merge lp://qastaging/~duckx-mezimail/bzr-externals/bzr-externals-setup
Reviewer Review Type Date Requested Status
Alexander Belchenko (community) Needs Fixing
Eugene Tarasenko Approve
Review via email: mp+21342@code.qastaging.launchpad.net

Description of the change

Implement a setup.py for future packaging

To post a comment you must log in.
Revision history for this message
Eugene Tarasenko (etarasenko) wrote :

Thanks!

review: Approve
Revision history for this message
Alexander Belchenko (bialix) wrote :

I don't think following bit is correct:

author="Canonical Ltd",

Revision history for this message
Alexander Belchenko (bialix) wrote :

Also shebang like that is bad idea:

#!/usr/bin/env python2.4

review: Needs Fixing
Revision history for this message
Eugene Tarasenko (etarasenko) wrote :

I fixed this strings and other.

Revision history for this message
Alexander Belchenko (bialix) wrote :

Eugene Tarasenko пишет:
> I fixed this strings and other.

OK.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches