OpenLP

Merge lp://qastaging/~dude-from-by/openlp/my-ios-remote into lp://qastaging/~danielborges93/openlp/ios-remote

  1. my-ios-remote
  2. Merge into ios-remote
Proposed by andrei
Status: Needs review
Proposed branch: lp://qastaging/~dude-from-by/openlp/my-ios-remote
Merge into: lp://qastaging/~danielborges93/openlp/ios-remote
Diff against target: 588 lines (+295/-48)
10 files modified
OLP RemoteTests/SettingsViewModelTests.swift (+77/-0)
Podfile (+1/-0)
Podfile.lock (+4/-1)
Remote.xcodeproj/project.pbxproj (+14/-0)
Remote/AppDelegate.swift (+11/-1)
Remote/Classes/Controller/Settings/SettingsControllerPresenter.swift (+2/-4)
Remote/Classes/Controller/Settings/SettingsViewController.swift (+24/-40)
Remote/Classes/Controller/Settings/SettingsViewModel.swift (+73/-0)
Remote/Classes/Network/Service.swift (+4/-2)
Remote/Classes/Util/CountlyClientSideUserPaths.swift (+85/-0)
To merge this branch: bzr merge lp://qastaging/~dude-from-by/openlp/my-ios-remote
Reviewer Review Type Date Requested Status
Daniel Borges Needs Fixing
Review via email: mp+324257@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2017-05-16.

Description of the change

Moved SettingsViewController to MVC and added tests
Added Countly and events

To post a comment you must log in.
Revision history for this message
andrei (dude-from-by) wrote :

Events are described in CountlyClientSideUserPaths.swift

first app launch start with no server ip
settings screen was opened without server ip filled
settings screen was closed with server ip filled
received server response - setup complete

Reply
Revision history for this message
Daniel Borges (danielborges93) wrote :

The application works well and the analytics too, but the tests aren't running. Can you take a look about this?

OBS: I put the current events on Wekan card.

review: Needs Fixing
Reply

Unmerged revisions

65. By andrei

Added countly analytics pod and added events to track users from from start to getting response from server

64. By andrei

Moved SettingsViewController.swift to MVC, added tests

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: