Merge lp://qastaging/~dyams/unity-2d/dash-to-Dash into lp://qastaging/unity-2d
Proposed by
Lohith D Shivamurthy
| Status: | Rejected |
|---|---|
| Rejected by: | Gerry Boland |
| Proposed branch: | lp://qastaging/~dyams/unity-2d/dash-to-Dash |
| Merge into: | lp://qastaging/unity-2d |
| Diff against target: |
26 lines (+2/-2) 2 files modified
places/Home.qml (+1/-1) places/app/places.cpp (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~dyams/unity-2d/dash-to-Dash |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gerry Boland | Pending | ||
|
Review via email:
|
|||
Description of the change
[dash] renamed dash.qml to Dash.qml
<coding standard>
All QML documents name begins with an uppercase letter.
<coding standard>
To post a comment you must log in.
Revision history for this message
| Gerry Boland (gerboland) wrote | # |
Unmerged revisions
- 826. By Lohith D Shivamurthy
-
[dash] renamed dash.qml to Dash.qml
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I cannot deny that this is an inconsistency, but for now I won't accept this. Until we adopt the Unity-Shell work, I don't want to make any major changes to our code base, to keep the delta small. If Unity-Shell preserves this (I doubt it), then we'll apply this.