unity-2d

Merge lp://qastaging/~dyams/unity-2d/launcher-DnD into lp://qastaging/unity-2d

  1. launcher-DnD
  2. Merge into trunk
Proposed by Lohith D Shivamurthy
Status: Merged
Approved by: Michał Sawicz
Approved revision: 814
Merged at revision: 887
Proposed branch: lp://qastaging/~dyams/unity-2d/launcher-DnD
Merge into: lp://qastaging/unity-2d
Diff against target: 179 lines (+138/-0)
3 files modified
libunity-2d-private/src/launcherapplication.cpp (+124/-0)
libunity-2d-private/src/launcherapplication.h (+5/-0)
tests/manual-tests/launcher.txt (+9/-0)
To merge this branch: bzr merge lp://qastaging/~dyams/unity-2d/launcher-DnD
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
Review via email: mp+84481@code.qastaging.launchpad.net

Description of the change

[launcher] support for drag-and-drop of files/folders

To post a comment you must log in.
Revision history for this message
Lohith D Shivamurthy (dyams) wrote :

More change description :
Content-type(s) of files dragged is compared with the mime-type(s) of the application.
If they match or fall under the same category, application is launched.

lp://qastaging/~dyams/unity-2d/launcher-DnD updated
808. By Lohith D Shivamurthy

[launcher] signal launchingChanged(true) is emitted after launching the application

809. By Lohith D Shivamurthy

[launcher] merge with trunk

810. By Lohith D Shivamurthy

[launcher] added a manual test

Revision history for this message
Michał Sawicz (saviq) wrote :

Hey, did you investigate giving at least cursor feedback for supported / nonsupported mimetypes?

review: Needs Information
Revision history for this message
Lohith D Shivamurthy (dyams) wrote :

> Hey, did you investigate giving at least cursor feedback for supported /
> nonsupported mimetypes?
Hey, not yet.

Revision history for this message
Michał Sawicz (saviq) wrote :

Functionally looks fine, except for the fact that launcher doesn't slide out in IntelliHide when you reach the edge when dragging, could you please investigate whether that's doable easily? That might require design input later (should the launcher show as soon as something is being dragged? maybe just the apps that support the mimetype should slide out?).

review: Needs Information
Revision history for this message
Lohith D Shivamurthy (dyams) wrote :

You are right, launcher didn't reveal while dragging something. I tried to modify edgeHitDetector to receive the drag event along with mouse move, but it didn't respond to drag events at all.Yes we might require design input too.

lp://qastaging/~dyams/unity-2d/launcher-DnD updated
811. By Lohith D Shivamurthy

[launcher] Append URL list directly

812. By Lohith D Shivamurthy

[launcher] Manual test updated

813. By Lohith D Shivamurthy

[launcher] Replaced a g_warning with UQ_WARNING

814. By Lohith D Shivamurthy

[launcher] Fix styling issues

Revision history for this message
Michał Sawicz (saviq) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches