Merge lp://qastaging/~dyams/unity-2d/launcher-desaturation into lp://qastaging/unity-2d

Proposed by Lohith D Shivamurthy
Status: Work in progress
Proposed branch: lp://qastaging/~dyams/unity-2d/launcher-desaturation
Merge into: lp://qastaging/unity-2d
Diff against target: 270 lines (+97/-8)
6 files modified
launcher/Launcher.qml (+1/-0)
launcher/LauncherItem.qml (+5/-0)
launcher/LauncherList.qml (+42/-1)
launcher/app/launcherview.cpp (+23/-1)
launcher/app/launcherview.h (+5/-0)
libunity-2d-private/src/iconimageprovider.cpp (+21/-6)
To merge this branch: bzr merge lp://qastaging/~dyams/unity-2d/launcher-desaturation
Reviewer Review Type Date Requested Status
Florian Boucault Pending
Review via email: mp+85490@code.qastaging.launchpad.net

Description of the change

[launcher][dash] While Dash is open hovering a tile will bring to normal otherwise tile is desaturated

To post a comment you must log in.
Revision history for this message
Lohith D Shivamurthy (dyams) wrote :

Change description:
Added new property 'isDashActive' to launcherView. LauncherItem already has mouseArea with hoverEnabled = true.
By listening to these two property changes we can achieve the desired effect.
QML icons provider is informed about the desaturated icon by appending :desaturate string to the icon id. The desaturate and tint effect is not perfect yet. At the moment it is achieved through QIcon and QPixmap, Which might need further tuning though.

825. By Lohith D Shivamurthy

Removed few unused lines

Revision history for this message
Florian Boucault (fboucault) wrote :

This work will be quite easier done once the dash and launcher are merged. Please hold off merging this one.

Revision history for this message
Lohith D Shivamurthy (dyams) wrote :

Currently this feature hardly depends on Dash. It is completely implemented inside launcher.
So I wonder how merging the dash and launcher would simplify this task! Unless there is going to be a significant change in launcher implementation though.

Revision history for this message
Florian Boucault (fboucault) wrote :

I was seeing that a big chunk of the diff was not going to be useful anymore in the future. Specifically the changes to:

=== modified file 'launcher/app/launcherview.h'
=== modified file 'launcher/app/launcherview.cpp'

Revision history for this message
Lohith D Shivamurthy (dyams) wrote :

Hey Florian, If you look at the change more closely, you might notice that there is a clear abstraction between launcher and dash notification.

<code>
connect(DashClient::instance(), SIGNAL(activePageChanged(const QString&)),SLOT(onDashActivePageChanged(const QString&)));
</code>

That is the only piece of change that informs the launcher about dash 'active' status.
So, there is not much change introduced in that regard.
If the above line is not required in future, We can remove/replace it any time.

Unmerged revisions

825. By Lohith D Shivamurthy

Removed few unused lines

824. By Lohith D Shivamurthy

[launcher][dash] While Dash is open hovering a tile will bring to normal otherwise tile is desaturated

823. By Lohith D Shivamurthy

[launcher] Initial commit for Desaturation and tint effect of launcher icons while dash is open

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches