Merge lp://qastaging/~dylanmccall/update-manager/group-by-applications into lp://qastaging/update-manager
Status: | Merged |
---|---|
Merged at revision: | 2582 |
Proposed branch: | lp://qastaging/~dylanmccall/update-manager/group-by-applications |
Merge into: | lp://qastaging/update-manager |
Diff against target: |
859 lines (+405/-239) 2 files modified
UpdateManager/Core/UpdateList.py (+175/-100) UpdateManager/UpdatesAvailable.py (+230/-139) |
To merge this branch: | bzr merge lp://qastaging/~dylanmccall/update-manager/group-by-applications |
Related bugs: | |
Related blueprints: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Dylan McCall (community) | Needs Resubmitting | ||
Barry Warsaw (community) | Needs Fixing | ||
Matthew Paul Thomas | Pending | ||
Review via email:
|
Description of the change
This is a first step towards grouping updates according to the specification at https:/
There are some details still to be worked out, but the feature so far is functional :)
Changes:
- Changed the list of updates to a treeview, where updates are collapsed under application names.
- UpdateList links updated packages to applications and groups them according to dependencies.
- Restart required indicator is shown for packages with "XB-Restart-
- Update origins are not displayed.
Known issues, to be resolved with future work:
- Indentation in the update tree view is presently hard coded and probably belongs (at least partly) in the light-themes package.
- The 'Ubuntu base' update group should list specific core packages, not 'everything else.' The specification is unclear on what to do with everything else, so it's like this for the time being.
- The Updates Required icon does not have its corresponding UI element below the download size text.
- The Download column does not yet show a check mark for downloaded packages.
- "Terminal" has an expander, with "gnome-terminal" as a child. Instead, group headers should simply be packages instead of their own things.
So, it isn't _finished_, but it does seem to be in a working state. The reason I'm interested in merging with trunk is because I want to keep our code in sync. Most of the crazy merge conflicts are probably done with now (especially since we seem to be standardized on 4 space indents). However, my diff spans _a lot_ of UpdateList.py and UpdatesAvailabl
See detailed review sent separately.