Merge lp://qastaging/~dynamite-a-d/ubuntu/precise/cmake/fix-for-972419 into lp://qastaging/ubuntu/precise/cmake

Proposed by David Dunsmore
Status: Work in progress
Proposed branch: lp://qastaging/~dynamite-a-d/ubuntu/precise/cmake/fix-for-972419
Merge into: lp://qastaging/ubuntu/precise/cmake
Diff against target: 43 lines (+23/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/99-cpack-corrupted-tarball-debs-fix.patch (+15/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://qastaging/~dynamite-a-d/ubuntu/precise/cmake/fix-for-972419
Reviewer Review Type Date Requested Status
Brian Murray Approve
Ubuntu branches Pending
Review via email: mp+123081@code.qastaging.launchpad.net

Description of the change

Fix for LP: #972419

To post a comment you must log in.
Revision history for this message
David Dunsmore (dynamite-a-d) wrote :
Revision history for this message
Brian Murray (brian-murray) wrote :

The patch tagging guidelines (https://wiki.ubuntu.com/PackagingGuide/PatchSystems?action=show&redirect=UbuntuDevelopment%2FPatchTaggingGuidelines#Patch_Tagging_Guidelines) indicate that patches should have information about where they originated from and bugs that they fix.

This information appears in your patch but has been left unchanged. I'd expect there to be a link to the patch's origin (http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a34015d3) and the author credited.

As I mentioned in the bug report this bug is already fixed in quantal, so we can setup a stable release update for 12.04 however we need a test case as part of the SRU process. For full details see: https://wiki.ubuntu.com/StableReleaseUpdates#Procedure.

Once we have that in the bug I'll be happy to add the tag information to the patch and upload this to precise-proposed.

review: Needs Fixing
Revision history for this message
Brian Murray (brian-murray) wrote :

To be clear I'd be happy to add the patch meta information for you and otherwise this debdiff looks good. Thanks for you work!

Revision history for this message
David Dunsmore (dynamite-a-d) wrote :

Thanks, that would be a great help

Revision history for this message
Brian Murray (brian-murray) wrote :

I've uploaded this to the precise-proposed queue now. Sorry for the delay.

review: Approve

Unmerged revisions

59. By David Dunsmore <email address hidden>

Fixes for corrupted tarballs when using DEB generator in CPack.
Fixes bug LP: 972419

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches