Merge into wily : nmu : Wily (15.10) : Code : audio-convert package : Ubuntu

Status:

Needs review

Proposed branch:

lp://qastaging/~e7appew/ubuntu/wily/audio-convert/nmu

Merge into:

lp://qastaging/ubuntu/wily/audio-convert

Diff against target:

776 lines (+397/-228)

16 files modified

audio-convert (+1/-1)
debian/changelog (+11/-0)
debian/compat (+1/-1)
debian/control (+8/-6)
debian/copyright (+33/-27)
debian/nautilus-script-audio-convert.install (+2/-0)
debian/patches/01_fix_unicode.patch (+98/-109)
debian/patches/02_fix_monkey_audio_detection.patch (+28/-0)
debian/patches/03_fix_musepack_conv.patch (+53/-0)
debian/patches/04_fix_id3_transfer.patch (+122/-0)
debian/patches/series (+4/-0)
debian/postinst (+0/-38)
debian/prerm (+0/-37)
debian/rules (+34/-8)
debian/source/format (+1/-0)
debian/watch (+1/-1)

To merge this branch:

bzr merge lp://qastaging/~e7appew/ubuntu/wily/audio-convert/nmu

Related bugs:

Bug #180451: nautilus-script-audio-convert fails to pass metadata tag to/from mp3 files	Medium	Confirmed
Bug #460749: Audio Convert script does not include codecs as dependencies or recommendations	Low	New
Bug #545544: "audio-convert" does not search/use mpcenc or mpcdec for musepack files	Medium	New

Link a bug report

Reviewer	Review Type	Date Requested	Status
Marc Deslauriers		2016-02-22	Needs Fixing on 2016-05-31
Review via email: mp+286759@code.qastaging.launchpad.net

Description of the change

* Bumped Standards Version to 3.9.6.
* Refreshed unicode patch to remove mojibake.
* Fix MusePack conversion (Closes LP: #545544).
* Fix transfer of ID3 tags (Closes LP: #180451).
* Bump suggested packages to recommended (Closes LP: #460749).

Revision history for this message

Marc Deslauriers (mdeslaur) wrote on 2016-05-31:

#

The merge proposal looks good, but please make the following changes so it can be uploaded to the development release (yakkety):

- Change version to 0.3.1.1-0ubuntu7 and target to yakkety
- Remove "Non-maintainer upload." line from changelog (Ubuntu has no maintainers)

Once that's done, please test build it, I couldn't get it to build in yakkety, it failed with the following error:

dh_install: Cannot find (any matches for) "=>" (tried in "." and "debian/tmp")
dh_install: missing files, aborting

Thanks!

review: Needs Fixing

Reply

lp://qastaging/~e7appew/ubuntu/wily/audio-convert/nmu updated on 2016-05-31

9. By Carlos Maddela on 2016-05-31: Bumped Standards Version to 3.9.8.
10. By Carlos Maddela on 2016-05-31: Refreshed unicode patch to remove mojibake.
11. By Carlos Maddela on 2016-05-31: Fix MusePack conversion (Closes LP: #545544).

Revision history for this message

Carlos Maddela (e7appew) wrote on 2016-05-31:

#

I have updated the changes as you have requested. I wasn't able to
reproduce the build error that you got, but I've made sure that it
builds in both xenial and yakkety.

On 31/05/16 22:43, Marc Deslauriers wrote:
> Review: Needs Fixing
>
> The merge proposal looks good, but please make the following changes so it can be uploaded to the development release (yakkety):
>
> - Change version to 0.3.1.1-0ubuntu7 and target to yakkety
> - Remove "Non-maintainer upload." line from changelog (Ubuntu has no maintainers)
>
> Once that's done, please test build it, I couldn't get it to build in yakkety, it failed with the following error:
>
> dh_install: Cannot find (any matches for) "=>" (tried in "." and "debian/tmp")
> dh_install: missing files, aborting
>
> Thanks!

Reply

lp://qastaging/~e7appew/ubuntu/wily/audio-convert/nmu updated on 2016-05-31

12. By Carlos Maddela on 2016-05-31: Fix transfer of ID3 tags (Closes LP: #180451).
13. By Carlos Maddela on 2016-05-31: Bump suggested packages to recommended (Closes LP: #460749).
14. By Carlos Maddela on 2016-05-31: Updated upstream URLs.
15. By Carlos Maddela on 2016-05-31: Release 0.3.1.1-0ubuntu7

Revision history for this message

Carlos Maddela (e7appew) wrote on 2016-06-05:

#

I was able to reproduce this build error in another project I've been
working on. The reason it occurs is that
debian/nautilus-script-audio-convert.install needs to be executable. I
have updated that file as executable in my local git repo, so I don't
understand why it hasn't propagated up to Launchpad. Perhaps there is a
bug in git-remote-bzr.

On 31/05/16 22:43, Marc Deslauriers wrote:
> Review: Needs Fixing
>
> The merge proposal looks good, but please make the following changes so it can be uploaded to the development release (yakkety):
>
> - Change version to 0.3.1.1-0ubuntu7 and target to yakkety
> - Remove "Non-maintainer upload." line from changelog (Ubuntu has no maintainers)
>
> Once that's done, please test build it, I couldn't get it to build in yakkety, it failed with the following error:
>
> dh_install: Cannot find (any matches for) "=>" (tried in "." and "debian/tmp")
> dh_install: missing files, aborting
>
> Thanks!

Reply

Unmerged revisions

15. By Carlos Maddela on 2016-05-31: Release 0.3.1.1-0ubuntu7
14. By Carlos Maddela on 2016-05-31: Updated upstream URLs.
13. By Carlos Maddela on 2016-05-31: Bump suggested packages to recommended (Closes LP: #460749).
12. By Carlos Maddela on 2016-05-31: Fix transfer of ID3 tags (Closes LP: #180451).
11. By Carlos Maddela on 2016-05-31: Fix MusePack conversion (Closes LP: #545544).
10. By Carlos Maddela on 2016-05-31: Refreshed unicode patch to remove mojibake.
9. By Carlos Maddela on 2016-05-31: Bumped Standards Version to 3.9.8.

Ubuntu
audio-convert package

Merge lp://qastaging/~e7appew/ubuntu/wily/audio-convert/nmu into lp://qastaging/ubuntu/wily/audio-convert

Commit message

Description of the change

Unmerged revisions

Preview Diff

Subscribers

Ubuntuaudio-convert package

Merge lp://qastaging/~e7appew/ubuntu/wily/audio-convert/nmu into lp://qastaging/ubuntu/wily/audio-convert

Commit message

Description of the change

Unmerged revisions

Preview Diff

Subscribers

Ubuntu
audio-convert package