Acire

Merge lp://qastaging/~edgar-b-dsouza/acire/gui_tweaks into lp://qastaging/acire

  1. gui_tweaks
  2. Merge into trunk
Proposed by Ed S
Status: Merged
Merged at revision: not available
Proposed branch: lp://qastaging/~edgar-b-dsouza/acire/gui_tweaks
Merge into: lp://qastaging/acire
Diff against target: 29 lines (+7/-1)
2 files modified
bin/acire (+5/-1)
data/ui/AcireWindow.ui (+2/-0)
To merge this branch: bzr merge lp://qastaging/~edgar-b-dsouza/acire/gui_tweaks
Reviewer Review Type Date Requested Status
Jono Bacon Approve
Review via email: mp+18690@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Ed S (edgar-b-dsouza) wrote :

Three revisions for some minor GUI tweaks, absence of which was annoying me as I played around with Acire, which I'm a fan of and have some ideas for... if I can figure out the code :)

(BTW: this is my first time with bzr, LP, collaborative dev; please correct me if it is wrong to push multiple minor revs at one go - thanks.)

Revs:
17 - Sort the treeview after filling, in ascending str.lower order of column 1, SNIPPET_NAME
18 - Set search column for snippets_tv to 1 (SNIPPET_NAME) via Glade, so typing with the treeview focused jumps to first snippet beginning with typed text
19 - Set Tooltip Column of snippets_tv to 3 (SNIPPET_DESCRIPTION) via Glade, to display description when mouse pointer hovers over item.

Please review, and thank you in advance for feedback.

Revision history for this message
Jono Bacon (jonobacon) wrote :

Awesome, Ed. I have merged this into the main code! :-)

review: Approve
Revision history for this message
Ed S (edgar-b-dsouza) wrote :

Thank you, Jono! :-)

Cheers,
Ed.

On Sun, Feb 7, 2010 at 2:50 AM, Jono Bacon <email address hidden> wrote:
> Review: Approve
> Awesome, Ed. I have merged this into the main code! :-)
> --
> https://code.edge.launchpad.net/~edgar-b-dsouza/acire/gui_tweaks/+merge/18690
> You are the owner of lp:~edgar-b-dsouza/acire/gui_tweaks.
>

--
Edgar D'Souza (http://edgar.b.dsouza.googlepages.com/)
ಠ_ಠ my GIMP-Python "Tear-off" plugin at: http://registry.gimp.org/node/10977
If Bill Gates had a penny for every time a Windows user had to reboot
their computer…oh wait, he does.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/acire'
2--- bin/acire 2010-01-12 10:06:43 +0000
3+++ bin/acire 2010-02-05 08:41:11 +0000
4@@ -313,7 +313,11 @@
5
6 self.snippets_model.append(templist)
7
8- templist = []
9+ templist = []
10+ #Sort the items in the treeview based on column 1, the text of each item
11+ rows = [tuple(r) + (i,) for i, r in enumerate(self.snippets_model)]
12+ rows.sort(key=lambda tup:(str.lower(tup[1])))
13+ self.snippets_model.reorder([r[-1] for r in rows])
14
15
16 def about(self, widget, data=None):
17
18=== modified file 'data/ui/AcireWindow.ui'
19--- data/ui/AcireWindow.ui 2010-01-10 19:06:57 +0000
20+++ data/ui/AcireWindow.ui 2010-02-05 08:41:11 +0000
21@@ -96,6 +96,8 @@
22 <object class="GtkTreeView" id="snippets_tv">
23 <property name="visible">True</property>
24 <property name="can_focus">True</property>
25+ <property name="search_column">1</property>
26+ <property name="tooltip_column">3</property>
27 <signal name="cursor_changed" handler="snippet_selected"/>
28 </object>
29 </child>

Subscribers

People subscribed via source and target branches

to all changes: