Acire

Merge lp://qastaging/~edgar-b-dsouza/acire/snippet_dependency_res_2 into lp://qastaging/acire

snippet_dependency_res_2
Merge into trunk

Proposed by Ed S on 2010-05-06

Status:	Needs review
Proposed branch:	lp://qastaging/~edgar-b-dsouza/acire/snippet_dependency_res_2
Merge into:	lp://qastaging/acire
Diff against target:	873 lines (+812/-2) 6 files modified acire/README.dep_checker.txt (+123/-0) acire/depchecker.py (+179/-0) acire/distropkgutils.py (+243/-0) acire/install_packages.py (+208/-0) acire/utils.py (+47/-0) bin/acire (+12/-2)
To merge this branch:	bzr merge lp://qastaging/~edgar-b-dsouza/acire/snippet_dependency_res_2
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Jono Bacon		2010-05-06	Needs Fixing on 2010-06-02
Review via email: mp+24813@code.qastaging.launchpad.net

Description of the change

Merged in snippet dependency checker against trunk rev 61.

The (newly added) README.dep_checker.txt file contains lots of info about the added files and how it hangs together.

I have tested earlier on Karmic and now on Lucid, with a Clutter script, and it works. Doesn't mean it's bug-free, of course :-) And from the performance viewpoint, I'd hope that contributors could change the check to a regex-based one, which ought to be faster.

Have incorporated your points from https://code.launchpad.net/~edgar-b-dsouza/acire/snippet_dependency_res_1/+merge/21924 as regards:

- Firefox-style yellow bar showing atop the GTKSourceView - in fact, the README contains your exact use case, copied from that merge proposal :-) (NB - I have been driven to almost leaving claw marks on the walls by the GtkLabel's wrapping behavior on Karmic and Lucid... every time I think I got it fixed, it springs out in a different way :-/ Somebody who can make that look decent, PLEASE fix the appearance).

- Keeping code out of bin/acire as much as possible - right, have done that, except for the few lines absolutely required to hook it up.

- Mechanism for hackers on other distros to add distro-specific package-handling code (of course, only tested on Ubuntu, may have bugs on other distros, needs to be tried out).

Looking forward to review - hope this one can be accepted to the trunk.

Thanks
Ed.

Revision history for this message

Jono Bacon (jonobacon) wrote on 2010-06-02:

Sorry for the delay, Ed! I just tested on Maverick and this doesn't work when I tested a snippet with Zeitgeist.

Revision history for this message

Jono Bacon (jonobacon) on 2010-06-02:

review: Needs Fixing

Revision history for this message

Ed S (edgar-b-dsouza) wrote on 2010-06-07:

Hi Jono,
I tried installing Maverick on an old laptop and ran into problems. Since I'm happily (for the most part) using Lucid on my main laptop, I don't want to put Maverick on that. I started installing into a VM to check, but got sidetracked by other stuff.

I hope to get around to debugging this soon. I think the error is probably in (my use of) the modulefinder module; if so, then I'm at a loss as to what to do, other than go the regex way :-( and I find that a bit too hard; could sure use help with that.

Did you try it with any other snippets that tried to import an unavailable module? Did the code work at least once on your system?

And when you tried it on the Zeitgeist snippet, were any messages printed to stdout (presuming you run Acire from a terminal)? Could you please share those, if any?

Thanks,
Ed.