Merge lp://qastaging/~elachuni/wsgi-oops/dont-iterate-weakkeydicts into lp://qastaging/wsgi-oops
Proposed by
Anthony Lenton
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Elliot Murphy | ||||
| Approved revision: | 50 | ||||
| Merged at revision: | 51 | ||||
| Proposed branch: | lp://qastaging/~elachuni/wsgi-oops/dont-iterate-weakkeydicts | ||||
| Merge into: | lp://qastaging/wsgi-oops | ||||
| Diff against target: |
13 lines (+2/-1) 1 file modified
canonical/oops/serializer.py (+2/-1) |
||||
| To merge this branch: | bzr merge lp://qastaging/~elachuni/wsgi-oops/dont-iterate-weakkeydicts | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Elliot Murphy (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Using iterators from weakkeydicts is not threadsafe, (see Python bug http://
This branch avoids using these iterators, to fix bug #574399.
Thanks MenTaLguY for spotting the fix!
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Nice fix!