Merge lp://qastaging/~elementary-apps/pantheon-photos/export-dialog-cleanup into lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Proposed by
Danielle Foré
| Status: | Merged |
|---|---|
| Approved by: | David Hewitt |
| Approved revision: | 3164 |
| Merged at revision: | 3166 |
| Proposed branch: | lp://qastaging/~elementary-apps/pantheon-photos/export-dialog-cleanup |
| Merge into: | lp://qastaging/~pantheon-photos/pantheon-photos/trunk |
| Diff against target: |
237 lines (+75/-94) 1 file modified
src/Dialogs/ExportDialog.vala (+75/-94) |
| To merge this branch: | bzr merge lp://qastaging/~elementary-apps/pantheon-photos/export-dialog-cleanup |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| David Hewitt | code, function | Approve | |
|
Review via email:
|
|||
Commit message
ExportDialog.vala:
* Better variable names
* GObject-style construction
* Code style
* Don't nest boxes
* Fix Dialog margins
* Spacing and alignment
* Properties, not impure functions
To post a comment you must log in.
Revision history for this message
| David Hewitt (davidmhewitt) wrote | # |
review:
Approve
(code, function)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks much neater, functionality still works.