Merge lp://qastaging/~elementary-apps/pantheon-photos/remove-title-option into lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Proposed by
Danielle Foré
| Status: | Rejected |
|---|---|
| Rejected by: | Corentin Noël |
| Proposed branch: | lp://qastaging/~elementary-apps/pantheon-photos/remove-title-option |
| Merge into: | lp://qastaging/~pantheon-photos/pantheon-photos/trunk |
| Diff against target: |
311 lines (+6/-113) 8 files modified
data/ui/media.ui (+0/-1) schemas/org.pantheon.photos.gschema.xml (+0/-6) src/CheckerboardLayout.vala (+6/-37) src/MediaPage.vala (+0/-24) src/Page.vala (+0/-6) src/PhotoPage.vala (+0/-6) src/camera/ImportPage.vala (+0/-32) src/config/GSettingsEngine.vala (+0/-1) |
| To merge this branch: | bzr merge lp://qastaging/~elementary-apps/pantheon-photos/remove-title-option |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Corentin Noël | Disapprove | ||
|
Review via email:
|
|||
Commit message
Remove option to hide photo titles
Description of the change
We don't allow hiding item titles in other views (Files, Videos, Music)
To post a comment you must log in.
Unmerged revisions
- 3139. By Danielle Foré
-
remove option to hide titles
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This option should maybe disappear from the DConf but I don't think it's a good idea to show per-photo names, it might be a "convenient" alternative to show a popover with the photo name if you really want to but the name is still available when clicking on a photo.
I think people have to name albums but no single photos.