Photos

Merge lp://qastaging/~elementary-apps/pantheon-photos/sidebar-duration into lp://qastaging/~pantheon-photos/pantheon-photos/trunk

  1. sidebar-duration
  2. Merge into trunk
Proposed by Danielle Foré
Status: Merged
Approved by: Zisu Andrei
Approved revision: 3052
Merged at revision: 3053
Proposed branch: lp://qastaging/~elementary-apps/pantheon-photos/sidebar-duration
Merge into: lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Diff against target: 16 lines (+5/-1)
1 file modified
src/sidebar/metadata/BasicProperties.vala (+5/-1)
To merge this branch: bzr merge lp://qastaging/~elementary-apps/pantheon-photos/sidebar-duration
Reviewer Review Type Date Requested Status
Zisu Andrei (community) code, functionality Approve
Review via email: mp+310355@code.qastaging.launchpad.net

Commit message

BasicProperties.vala: Create duration label without mystery meat method

Description of the change

It's obvious from units that this is a duration. No extra label needed

To post a comment you must log in.
Revision history for this message
Zisu Andrei (matzipan) wrote :

What if it's more than 60 seconds?

review: Needs Information
Revision history for this message
Danielle Foré (danrabbit) wrote :

Fixing that issue is outside the scope of this branch

lp://qastaging/~elementary-apps/pantheon-photos/sidebar-duration updated
3052. By Danielle Foré

use ngettext

Revision history for this message
Zisu Andrei (matzipan) :
review: Approve (code, functionality)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches