Merge lp://qastaging/~elementary-apps/pantheon-photos/sidebar-extra-props into lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Proposed by
Danielle Foré
| Status: | Merged |
|---|---|
| Approved by: | Felipe Escoto |
| Approved revision: | 3038 |
| Merged at revision: | 3041 |
| Proposed branch: | lp://qastaging/~elementary-apps/pantheon-photos/sidebar-extra-props |
| Merge into: | lp://qastaging/~pantheon-photos/pantheon-photos/trunk |
| Diff against target: |
79 lines (+1/-13) 1 file modified
src/sidebar/metadata/ExtendedProperties.vala (+1/-13) |
| To merge this branch: | bzr merge lp://qastaging/~elementary-apps/pantheon-photos/sidebar-extra-props |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Photos Devs | Pending | ||
|
Review via email:
|
|||
Commit message
ExtendedPropert
Description of the change
This is pretty opinionated so I guess I need some opinions. But I think these properties are just generally unhelpful and don't help me make any kind of decision.
Why does it matter what software was running on my camera?
Do I really care where this photo is on the filesystem? I can right-click and show the file if I need to get to it for some reason. This isn't a link or anything so it's not like it's convenient.
What is the original size useful for? So I know this photo was scaled down or cropped in some way. Now what? Is this useful info to someone?
To post a comment you must log in.
Revision history for this message
| Felipe Escoto (philip.scott) wrote | # |
Revision history for this message
| Danielle Foré (danrabbit) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The only property i disagree with removing is the filesystem info. Since we do the automatic importing, it could be nice to know where the photo is without having to depend on Files.