Merge lp://qastaging/~elementary-apps/pantheon-photos/sidebar-geo into lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Proposed by
Danielle Foré
| Status: | Merged |
|---|---|
| Approved by: | Felipe Escoto |
| Approved revision: | 3053 |
| Merged at revision: | 3059 |
| Proposed branch: | lp://qastaging/~elementary-apps/pantheon-photos/sidebar-geo |
| Merge into: | lp://qastaging/~pantheon-photos/pantheon-photos/trunk |
| Diff against target: |
163 lines (+52/-16) 3 files modified
CMakeLists.txt (+2/-0) src/sidebar/metadata/BasicProperties.vala (+50/-0) src/sidebar/metadata/ExtendedProperties.vala (+0/-16) |
| To merge this branch: | bzr merge lp://qastaging/~elementary-apps/pantheon-photos/sidebar-geo |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Felipe Escoto (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Metadata Sidebar: Get a human-readable location from gps data
Description of the change
This needs to be tested for locations that might not have town or state fields and we need to figure out smart fallbacks
To post a comment you must log in.
Revision history for this message
| Danielle Foré (danrabbit) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Felipe's change works for me :)