Photos

Merge lp://qastaging/~elementary-apps/pantheon-photos/soup-deprecations into lp://qastaging/~pantheon-photos/pantheon-photos/trunk

  1. soup-deprecations
  2. Merge into trunk
Proposed by Danielle Foré
Status: Merged
Approved by: Felipe Escoto
Approved revision: 3071
Merged at revision: 3111
Proposed branch: lp://qastaging/~elementary-apps/pantheon-photos/soup-deprecations
Merge into: lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Diff against target: 56 lines (+12/-12)
2 files modified
plugins/pantheon-photos-publishing-extras/RESTSupport.vala (+6/-6)
plugins/pantheon-photos-publishing/RESTSupport.vala (+6/-6)
To merge this branch: bzr merge lp://qastaging/~elementary-apps/pantheon-photos/soup-deprecations
Reviewer Review Type Date Requested Status
Felipe Escoto (community) Approve
Review via email: mp+311526@code.qastaging.launchpad.net

Commit message

Fix deprecation warnings with Soup Status

Description of the change

-

To post a comment you must log in.
lp://qastaging/~elementary-apps/pantheon-photos/soup-deprecations updated
3071. By Danielle Foré

resolve soup deprecation warnings

Revision history for this message
Felipe Escoto (philip.scott) wrote :

There are some more warnings on the plugins:

/video-thumbnail/plugins/pantheon-photos-publishing/FacebookPublishing, REST, Picasa and Youtube :)

Not sure if you also want to kill them all on this run

review: Needs Fixing
Revision history for this message
Danielle Foré (danrabbit) wrote :

Naw I wasn't able to really figure other the other warnings. This branch is just for the KnownStatusCode deprecation

Revision history for this message
Felipe Escoto (philip.scott) wrote :

LGTM and it still works!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches