Merge lp://qastaging/~elementary-apps/pantheon-photos/video-thumbnail into lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Proposed by
Danielle Foré
| Status: | Merged |
|---|---|
| Approved by: | Felipe Escoto |
| Approved revision: | 3071 |
| Merged at revision: | 3081 |
| Proposed branch: | lp://qastaging/~elementary-apps/pantheon-photos/video-thumbnail |
| Merge into: | lp://qastaging/~pantheon-photos/pantheon-photos/trunk |
| Diff against target: |
192 lines (+45/-87) 5 files modified
data/icons/noninterpretable-video.svg (+43/-0) src/MediaPage.vala (+1/-79) src/Resources.vala (+1/-1) src/Thumbnail.vala (+0/-3) src/camera/ImportPage.vala (+0/-4) |
| To merge this branch: | bzr merge lp://qastaging/~elementary-apps/pantheon-photos/video-thumbnail |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Photos Devs | Pending | ||
|
Review via email:
|
|||
Commit message
Remove the "sprocket" from video thumbnails and replace the thumbnail image
Description of the change
Gets rid of the dumb sprocket and replaces the placeholder thumbnail with something a little simpler.
It's still not ideal, we're presenting a pixbuf instead of a gtk.image and ideally I think I'd like to do this with native widgets and icons and not have an image at all here. But It's way less code than the old thing
To test this you'll need to make install and to clear your video thumbnails in .cache/
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
