Merge lp://qastaging/~elementary-dev-community/audience/prevent-screen-timeout into lp://qastaging/~audience-members/audience/trunk

Proposed by Cameron Norman
Status: Rejected
Rejected by: Cody Garver
Proposed branch: lp://qastaging/~elementary-dev-community/audience/prevent-screen-timeout
Merge into: lp://qastaging/~audience-members/audience/trunk
Diff against target: 64 lines (+22/-1)
3 files modified
src/CMakeLists.txt (+3/-1)
src/Widgets/VideoPlayer.vala (+12/-0)
vapi/DPMS.vapi (+7/-0)
To merge this branch: bzr merge lp://qastaging/~elementary-dev-community/audience/prevent-screen-timeout
Reviewer Review Type Date Requested Status
Viko Adi Rahmawan (community) Disapprove
xapantu (community) Needs Fixing
Review via email: mp+262939@code.qastaging.launchpad.net

Commit message

Disable DPMS to prevent screensaver and locking

Description of the change

Disable DPMS to prevent screensaver and locking

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

I would prefer if this was a build flag instead so this x dependency becomes optional

Revision history for this message
xapantu (xapantu) wrote :

Yes, we want to avoid hard-dependency on X as we are slowly switching to wayland in the years to come.

On top of that, maybe that could be done at a gala level, I think we should disallow screen-timeout when a video player is launched/playing (but we can add this to audience for now).

review: Needs Fixing
Revision history for this message
Viko Adi Rahmawan (vikoadi) wrote :

this is definitely not the way to go,
the problem is in os level and should be fixed there
audience have done enough to signal inhibit to sessionmanager

maybe we should have a daemon equal to gnomepower or fix gnome power management to inhibit our lockscreen

review: Disapprove

Unmerged revisions

530. By Cameron Norman

Disable DPMS to prevent screensaver and locking

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches