Merge lp://qastaging/~elementary-dev-community/beat-box/refactor into lp://qastaging/beat-box
Proposed by
xapantu
| Status: | Merged |
|---|---|
| Merged at revision: | 677 |
| Proposed branch: | lp://qastaging/~elementary-dev-community/beat-box/refactor |
| Merge into: | lp://qastaging/beat-box |
| Diff against target: |
1033 lines (+368/-360) 11 files modified
CMakeLists.txt (+1/-0) core/CMakeLists.txt (+21/-0) core/Library/ComputerLibrary.vala (+2/-0) core/Library/DeviceLibrary.vala (+2/-0) core/Library/Library.vala (+2/-0) core/tests/main.vala (+8/-0) src/CMakeLists.txt (+1/-0) src/Core/CoverManager.vala (+243/-0) src/Core/FileOperator.vala (+3/-113) src/Core/LibraryManager.vala (+42/-96) src/GStreamer/GStreamerTagger.vala (+43/-151) |
| To merge this branch: | bzr merge lp://qastaging/~elementary-dev-community/beat-box/refactor |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Victor Martinez (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
* Don't use a LibraryManager in GStreamerTagger.
* Tie all the covers related things in one class. The code is easier to understand for a newcomer this way.
To post a comment you must log in.
Revision history for this message
| Scott Ringwelski (sgringwe) wrote | # |
Revision history for this message
| Scott Ringwelski (sgringwe) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Nice!