Granite

Merge lp://qastaging/~elementary-dev-community/granite/fix-1324424 into lp://qastaging/~elementary-pantheon/granite/granite

  1. fix-1324424
  2. Merge into granite
Proposed by Cameron Norman
Status: Merged
Merged at revision: 765
Proposed branch: lp://qastaging/~elementary-dev-community/granite/fix-1324424
Merge into: lp://qastaging/~elementary-pantheon/granite/granite
Diff against target: 53 lines (+18/-2)
2 files modified
CMakeLists.txt (+10/-2)
lib/Application.vala (+8/-0)
To merge this branch: bzr merge lp://qastaging/~elementary-dev-community/granite/fix-1324424
Reviewer Review Type Date Requested Status
xapantu (community) Approve
Review via email: mp+229547@code.qastaging.launchpad.net

Description of the change

This patch just uses some ifdefs to use setproctitle instead of prctl on *BSD systems.

To post a comment you must log in.
Revision history for this message
Cameron Norman (cameronnemo) wrote :

I should mention that the original author is Olivier Duchateau, I just applied his patch to a recent granite to make it easier to merge for you guys.

Revision history for this message
xapantu (xapantu) wrote :

It looks fine - thanks for your work. I didn't test the *BSD part, I assume that you or Olivier Duchateau tested it.

I am going to merge this with an upper case style (i.e DRAGON_FLY instead of DragonFly).

review: Approve
Revision history for this message
Raphael Isemann (teemperor) wrote :

I don't think we can actually test it on all platforms such as FreeBSD because they don't have the necessary version of some libs (vala and GTK+ for example). It doesn't break anything on elementary OS so +1 for merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches