Merge lp://qastaging/~elementary-os/indicator-sound/onlyshowin-add-pantheon into lp://qastaging/indicator-sound/14.04

Proposed by Sergey "Shnatsel" Davidoff
Status: Superseded
Proposed branch: lp://qastaging/~elementary-os/indicator-sound/onlyshowin-add-pantheon
Merge into: lp://qastaging/indicator-sound/14.04
Diff against target: 25 lines (+2/-2)
2 files modified
data/indicator-sound.desktop.in (+1/-1)
data/indicator-sound.upstart.desktop.in (+1/-1)
To merge this branch: bzr merge lp://qastaging/~elementary-os/indicator-sound/onlyshowin-add-pantheon
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+214235@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2014-06-11.

Description of the change

Add Pantheon, the desktop environment of elementary Project, to OnlyShowIn lists in .desktop files.

Pantheon currently relies on Ayatana indicators; this change will allow installing Pantheon in Ubuntu without requiring elementary-patched indicator packages (bug #1301699).

This indicator shows up and appears to be fully functional in Pantheon after this change.

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

LGTM. Thanks for the patch, Sergey :)

review: Approve
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Thanks for the review! :)

Any word on when this is going to be actually merged?

Unmerged revisions

442. By Sergey "Shnatsel" Davidoff

Add Pantheon to OnlyShowIn list in the .desktop files

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches