Merge lp://qastaging/~elopio/selenium-simple-test/fix1166408-assert_text_with_no_text into lp://qastaging/selenium-simple-test

Proposed by Leo Arias
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 370
Merged at revision: 369
Proposed branch: lp://qastaging/~elopio/selenium-simple-test/fix1166408-assert_text_with_no_text
Merge into: lp://qastaging/selenium-simple-test
Diff against target: 71 lines (+41/-1)
3 files modified
src/sst/actions.py (+5/-1)
src/sst/selftests/assert_text.py (+35/-0)
src/testproject/templates/index.html (+1/-0)
To merge this branch: bzr merge lp://qastaging/~elopio/selenium-simple-test/fix1166408-assert_text_with_no_text
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Approve
Review via email: mp+157897@code.qastaging.launchpad.net

Commit message

Print a better message when the element has no text.

To post a comment you must log in.
Revision history for this message
Vincent Ladeuil (vila) wrote :

70 === modified file 'src/testproject/testproj.db'
71 Binary files src/testproject/testproj.db 2013-01-23 15:18:53 +0000 and src/testproject/testproj.db 2013-04-09 15:26:24 +0000 differ

http://pad.lv/1104861 /me sighs

Consider 'bzr revert src/testproject/testproj.db --no-backup' before committing next time ?

Other than that, good job !

review: Approve
Revision history for this message
Vincent Ladeuil (vila) wrote :

And thanks for the added tests !

Revision history for this message
Leo Arias (elopio) wrote :

Ow, I always forget about that testproj :S
Thanks for the review Vincent.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches