Merge lp://qastaging/~elopio/snapcraft/base_plugin_tests into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Leo Arias
| Status: | Merged |
|---|---|
| Approved by: | Michael Terry |
| Approved revision: | 125 |
| Merged at revision: | 119 |
| Proposed branch: | lp://qastaging/~elopio/snapcraft/base_plugin_tests |
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
| Diff against target: |
202 lines (+129/-10) 5 files modified
debian/control (+2/-0) snapcraft/__init__.py (+1/-4) snapcraft/common.py (+1/-1) snapcraft/tests/__init__.py (+2/-1) snapcraft/tests/test_base_plugin.py (+123/-4) |
| To merge this branch: | bzr merge lp://qastaging/~elopio/snapcraft/base_plugin_tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Terry (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Added unit tests for the base plugin.
Added python3-
Description of the change
The important parts of this branch are:
- added a simple local server to test downloads.
- added test scenarios to simplify repetitive unit tests. (already installed in tarmac.)
Once I put this into test I found a bug I introduced by leaving the argument in the fatal function.
I also simplified the makedirs method.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks great, thanks, especially the fatal() typo fix! :)
But you'll want to add wget to Build-Depends too (we didn't use it during tests before).