Snapcraft

Merge lp://qastaging/~elopio/snapcraft/coverage into lp://qastaging/~snappy-dev/snapcraft/core

coverage
Merge into core

Proposed by Leo Arias on 2015-07-21

Status:	Merged
Approved by:	Michael Terry on 2015-07-21
Approved revision:	no longer in the source branch.
Merged at revision:	92
Proposed branch:	lp://qastaging/~elopio/snapcraft/coverage
Merge into:	lp://qastaging/~snappy-dev/snapcraft/core
Diff against target:	34 lines (+12/-1) 2 files modified README.md (+5/-0) runtests.sh (+7/-1)
To merge this branch:	bzr merge lp://qastaging/~elopio/snapcraft/coverage
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Michael Terry (community)		2015-07-21	Approve on 2015-07-21
Review via email: mp+265350@code.qastaging.launchpad.net

Commit message

Add test coverage report.

Revision history for this message

Michael Terry (mterry) wrote on 2015-07-21:

Nice! :)

Is there any way we could include the plainbox runs in the coverage report? The unit tests are only a part of the story, and so the coverage report would be misleading without the integration tests too.

review: Needs Information

lp://qastaging/~elopio/snapcraft/coverage updated on 2015-07-21

91. By Michael Vogt on 2015-07-21: Fix setting of snapcraft.common.plugindir (thanks to cjwatson). by mvo approved by mterry

Revision history for this message

Leo Arias (elopio) wrote on 2015-07-21:

I haven't been able to run the plainbox tests on vivid yet. I get:

usage: manage.py [--help] [--version] [options]
manage.py: error: unrecognized arguments: -d /tmp/tmp.FrgNhrCr9x

I have the ppa mentioned on the README. I'll ask on IRC.

I'm not sure if we want a unified report of unit test + functional test coverage, or we want to reports. We have the same question for go, so we'll be talking about that. Anyway, we can add that in a following branch.

Revision history for this message

Leo Arias (elopio) wrote on 2015-07-21:

I found I was missing an update. But it seems python3-coverage can run only python files. We'll have to see how to make it work with plainbox.

Revision history for this message

Michael Terry (mterry) wrote on 2015-07-21:

OK, this is fine/harmless. I just don't want us to get caught up in chasing those numbers, since they aren't super useful without incorporating the integration tests.

review: Approve

lp://qastaging/~elopio/snapcraft/coverage updated on 2015-07-21