Snapcraft

Merge lp://qastaging/~elopio/snapcraft/dep8 into lp://qastaging/~snappy-dev/snapcraft/core

  1. dep8
  2. Merge into core
Proposed by Leo Arias
Status: Rejected
Rejected by: Leo Arias
Proposed branch: lp://qastaging/~elopio/snapcraft/dep8
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 112 lines (+58/-29)
3 files modified
debian/tests/control (+8/-0)
integration-tests/runtests.sh (+48/-0)
runtests.sh (+2/-29)
To merge this branch: bzr merge lp://qastaging/~elopio/snapcraft/dep8
Reviewer Review Type Date Requested Status
Leo Arias (community) Disapprove
Review via email: mp+266998@code.qastaging.launchpad.net

Commit message

Added dep8 tests.

To post a comment you must log in.
lp://qastaging/~elopio/snapcraft/dep8 updated
122. By Leo Arias

Run all the tests, as suggested by mterry.

123. By Leo Arias

Added the unittest dependencies.

Revision history for this message
Leo Arias (elopio) wrote :

can't get it to work yet. Back to work in progress.

lp://qastaging/~elopio/snapcraft/dep8 updated
124. By Leo Arias

Typo.

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

why is this work in progress?

Revision history for this message
Leo Arias (elopio) wrote :

because it was failing and I switched to other task before understanding the error.

Revision history for this message
Leo Arias (elopio) wrote :

Already merged into daniel's branch. Which is a lot better because it actually works.

review: Disapprove
Revision history for this message
Leo Arias (elopio) wrote :

https://code.launchpad.net/~dholbach/snapcraft/1496392/+merge/271319

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: