Merge lp://qastaging/~elopio/snapcraft/fix1474022-lower_case into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Leo Arias
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Michael Terry | ||||
| Approved revision: | 81 | ||||
| Merged at revision: | 76 | ||||
| Proposed branch: | lp://qastaging/~elopio/snapcraft/fix1474022-lower_case | ||||
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core | ||||
| Diff against target: |
591 lines (+93/-93) 12 files modified
snapcraft/__init__.py (+6/-6) snapcraft/cmds.py (+10/-10) snapcraft/common.py (+2/-2) snapcraft/plugin.py (+32/-32) snapcraft/plugins/autotools_project.py (+2/-2) snapcraft/plugins/cmake_project.py (+1/-1) snapcraft/plugins/go14.py (+1/-1) snapcraft/plugins/make_project.py (+1/-1) snapcraft/plugins/ubuntu.py (+11/-11) snapcraft/yaml.py (+15/-15) tests/unit/test_cmds.py (+4/-4) tests/unit/test_plugin.py (+8/-8) |
||||
| To merge this branch: | bzr merge lp://qastaging/~elopio/snapcraft/fix1474022-lower_case | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Terry (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Refactored all methods to be lowercase, following pep8.
Description of the change
Still missing: lowercase attributes and arguments.
To post a comment you must log in.
Revision history for this message
| Michael Terry (mterry) wrote | # |
Revision history for this message
| Leo Arias (elopio) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Missed one internal function I noticed, but otherwise seems fine, yeah. Thanks :)