Snapcraft

Merge lp://qastaging/~elopio/snapcraft/fix1474022-lower_case2 into lp://qastaging/~snappy-dev/snapcraft/core

  1. fix1474022-lower_case2
  2. Merge into core
Proposed by Leo Arias
Status: Merged
Approved by: Michael Terry
Approved revision: 83
Merged at revision: 79
Proposed branch: lp://qastaging/~elopio/snapcraft/fix1474022-lower_case2
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Prerequisite: lp://qastaging/~elopio/snapcraft/fix1474022-lower_case
Diff against target: 273 lines (+48/-48)
4 files modified
snapcraft/cmds.py (+3/-3)
snapcraft/plugin.py (+14/-14)
snapcraft/plugins/ubuntu.py (+9/-9)
snapcraft/yaml.py (+22/-22)
To merge this branch: bzr merge lp://qastaging/~elopio/snapcraft/fix1474022-lower_case2
Reviewer Review Type Date Requested Status
Michael Terry (community) Approve
Review via email: mp+264611@code.qastaging.launchpad.net

Commit message

Refactored all the attributes to be lowercase, following pep8.

Description of the change

Still missing: arguments and internal variables

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

Noted a change that we don't want to make yet.

review: Needs Fixing
lp://qastaging/~elopio/snapcraft/fix1474022-lower_case2 updated
83. By Leo Arias

Revert the change of systemPackages.

Revision history for this message
Leo Arias (elopio) wrote :

done. Thanks for the review.

Revision history for this message
Michael Terry (mterry) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: