Merge lp://qastaging/~elopio/snapcraft/fix1474022-lower_case3 into lp://qastaging/~snappy-dev/snapcraft/core

Proposed by Leo Arias
Status: Merged
Approved by: Michael Terry
Approved revision: 84
Merged at revision: 81
Proposed branch: lp://qastaging/~elopio/snapcraft/fix1474022-lower_case3
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Prerequisite: lp://qastaging/~elopio/snapcraft/fix1474022-lower_case2
Diff against target: 154 lines (+24/-24)
4 files modified
snapcraft/cmds.py (+2/-2)
snapcraft/plugin.py (+13/-13)
snapcraft/yaml.py (+7/-7)
tests/unit/test_plugin.py (+2/-2)
To merge this branch: bzr merge lp://qastaging/~elopio/snapcraft/fix1474022-lower_case3
Reviewer Review Type Date Requested Status
Michael Terry (community) Approve
Review via email: mp+264617@code.qastaging.launchpad.net

Commit message

Refactored all arguments to be lowercase, following pep8.

Description of the change

Still missing: internal variable names.

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

LGTM

review: Approve
Revision history for this message
Snappy Tarmac (snappydevtarmac) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Revision history for this message
Michael Terry (mterry) wrote :

Still looks fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: