Snapcraft

Merge lp://qastaging/~elopio/snapcraft/fix1477638-format_strings-2 into lp://qastaging/~snappy-dev/snapcraft/core

  1. fix1477638-format_strings-2
  2. Merge into core
Proposed by Leo Arias
Status: Merged
Approved by: Leo Arias
Approved revision: 117
Merged at revision: 112
Proposed branch: lp://qastaging/~elopio/snapcraft/fix1477638-format_strings-2
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Prerequisite: lp://qastaging/~elopio/snapcraft/fix1477638-format_strings1
Diff against target: 163 lines (+66/-29)
2 files modified
snapcraft/plugin.py (+6/-7)
snapcraft/tests/test_plugin.py (+60/-22)
To merge this branch: bzr merge lp://qastaging/~elopio/snapcraft/fix1477638-format_strings-2
Reviewer Review Type Date Requested Status
Michael Terry (community) Approve
Review via email: mp+265717@code.qastaging.launchpad.net

Commit message

Use the format string in plugin.py

To post a comment you must log in.
lp://qastaging/~elopio/snapcraft/fix1477638-format_strings-2 updated
113. By Leo Arias

Prettify the code.

114. By Leo Arias

Typo

115. By Leo Arias

Use the format method in load_plugin.

116. By Leo Arias

Removed the !r as suggested by mterry

Revision history for this message
Michael Terry (mterry) wrote :

I'm fine with content, but you have a conflict with trunk

review: Approve
lp://qastaging/~elopio/snapcraft/fix1477638-format_strings-2 updated
117. By Leo Arias

Merged with trunk.

Revision history for this message
Leo Arias (elopio) wrote :

There's no conflict anymore, so I'll top approve.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: