Snapcraft

Merge lp://qastaging/~elopio/snapcraft/fix1497371-clean_clean into lp://qastaging/~snappy-dev/snapcraft/core

  1. fix1497371-clean_clean
  2. Merge into core
Proposed by Leo Arias
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 183
Merged at revision: 181
Proposed branch: lp://qastaging/~elopio/snapcraft/fix1497371-clean_clean
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 68 lines (+10/-4)
3 files modified
integration-tests/units/jobs.pxu (+3/-1)
snapcraft/cmds.py (+2/-1)
snapcraft/tests/test_cmds.py (+5/-2)
To merge this branch: bzr merge lp://qastaging/~elopio/snapcraft/fix1497371-clean_clean
Reviewer Review Type Date Requested Status
Sergio Schvezov Approve
Review via email: mp+271684@code.qastaging.launchpad.net

Commit message

On clean, check the contents of the parts dir only if it exists.

To post a comment you must log in.
lp://qastaging/~elopio/snapcraft/fix1497371-clean_clean updated
182. By Leo Arias

80 column

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Nice catch!

How about a test that runs clean twice? :-)

lp://qastaging/~elopio/snapcraft/fix1497371-clean_clean updated
183. By Leo Arias

Added a second call to clean in integration tests.

Revision history for this message
Sergio Schvezov (sergiusens) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: